Bug 95942 - [GTK] Multiple feature defines in webcore_cppflags can occur
Summary: [GTK] Multiple feature defines in webcore_cppflags can occur
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 00:34 PDT by Zan Dobersek
Modified: 2012-09-07 09:01 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2012-09-06 00:53 PDT, Zan Dobersek 		mrobinson: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-09-06 00:34:58 PDT 
[GTK] Multiple feature defines in webcore_cppflags can occur
Comment 1 Zan Dobersek 2012-09-06 00:53:25 PDT 
Created attachment 162442 [details]
Patch
Comment 2 Zan Dobersek 2012-09-06 00:58:31 PDT 
Hi Martin, I'd be thankful for a review of this workaround.
Comment 3 Martin Robinson 2012-09-06 14:37:10 PDT 
Comment on attachment 162442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review

Looks good, though I have a small suggestion for a rename.

> Source/WebCore/GNUmakefile.am:773
> +feature_defines_unstable_features +=

How about unstable_feature_defines? It avoids using the word "features" twice in this variable name.
Comment 4 Zan Dobersek 2012-09-07 04:34:27 PDT 
Comment on attachment 162442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review

>> Source/WebCore/GNUmakefile.am:773
>> +feature_defines_unstable_features +=
> 
> How about unstable_feature_defines? It avoids using the word "features" twice in this variable name.

Yes, the repetition should be avoided. How about feature_defines_unstable, though? Just so to keep the 'feature_defines_' prefix.
Comment 5 Martin Robinson 2012-09-07 08:48:33 PDT 
(In reply to comment #4)
> (From update of attachment 162442 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review

> Yes, the repetition should be avoided. How about feature_defines_unstable, though? Just so to keep the 'feature_defines_' prefix.

I think we should try to move away from unnatural English in variable names where possible, but this is fine with me.
Comment 6 Zan Dobersek 2012-09-07 09:01:25 PDT 
Committed r127872: <http://trac.webkit.org/changeset/127872>