RESOLVED FIXED 95942
[GTK] Multiple feature defines in webcore_cppflags can occur 
https://bugs.webkit.org/show_bug.cgi?id=95942
Summary [GTK] Multiple feature defines in webcore_cppflags can occur
Zan Dobersek
Reported 2012-09-06 00:34:58 PDT
[GTK] Multiple feature defines in webcore_cppflags can occur
Attachments
Patch (4.19 KB, patch)
2012-09-06 00:53 PDT, Zan Dobersek 		mrobinson: review+
mrobinson: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-09-06 00:53:25 PDT
Created attachment 162442 [details] Patch
Zan Dobersek
Comment 2 2012-09-06 00:58:31 PDT
Hi Martin, I'd be thankful for a review of this workaround.
Martin Robinson
Comment 3 2012-09-06 14:37:10 PDT
Comment on attachment 162442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review Looks good, though I have a small suggestion for a rename. > Source/WebCore/GNUmakefile.am:773 > +feature_defines_unstable_features += How about unstable_feature_defines? It avoids using the word "features" twice in this variable name.
Zan Dobersek
Comment 4 2012-09-07 04:34:27 PDT
Comment on attachment 162442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review >> Source/WebCore/GNUmakefile.am:773 >> +feature_defines_unstable_features += > > How about unstable_feature_defines? It avoids using the word "features" twice in this variable name. Yes, the repetition should be avoided. How about feature_defines_unstable, though? Just so to keep the 'feature_defines_' prefix.
Martin Robinson
Comment 5 2012-09-07 08:48:33 PDT
(In reply to comment #4) > (From update of attachment 162442 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162442&action=review > Yes, the repetition should be avoided. How about feature_defines_unstable, though? Just so to keep the 'feature_defines_' prefix. I think we should try to move away from unnatural English in variable names where possible, but this is fine with me.
Zan Dobersek
Comment 6 2012-09-07 09:01:25 PDT
Committed r127872: <http://trac.webkit.org/changeset/127872>
Note You need to log in before you can comment on or make changes to this bug.