Bug 95938 - Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
Summary: Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 23:57 PDT by Luke Macpherson
Modified: 2012-09-07 00:47 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2012-09-06 00:00 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (4.86 KB, patch)
2012-09-06 17:30 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch for landing (5.30 KB, patch)
2012-09-06 21:53 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2012-09-05 23:57:45 PDT 
Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
Comment 1 Luke Macpherson 2012-09-06 00:00:40 PDT 
Created attachment 162430 [details]
Patch
Comment 2 Peter Beverloo (cr-android ews) 2012-09-06 02:49:58 PDT 
Comment on attachment 162430 [details]
Patch

Attachment 162430 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13757935
Comment 3 Andreas Kling 2012-09-06 04:48:40 PDT 
Comment on attachment 162430 [details]
Patch

Great, r=me.

Just make sure to fix the EWS warning first:
CSSPrimitiveValue.cpp:368:12: error: enumeration value 'CSS_DASHBOARD_REGION' not handled in switch [-Werror=switch]
Comment 4 WebKit Review Bot 2012-09-06 14:32:48 PDT 
Comment on attachment 162430 [details]
Patch

Attachment 162430 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13772433
Comment 5 Luke Macpherson 2012-09-06 17:30:48 PDT 
Created attachment 162628 [details]
Patch for landing
Comment 6 Early Warning System Bot 2012-09-06 18:29:23 PDT 
Comment on attachment 162628 [details]
Patch for landing

Attachment 162628 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13778387
Comment 7 Build Bot 2012-09-06 18:35:37 PDT 
Comment on attachment 162628 [details]
Patch for landing

Attachment 162628 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13765819
Comment 8 Gyuyoung Kim 2012-09-06 19:21:14 PDT 
Comment on attachment 162628 [details]
Patch for landing

Attachment 162628 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13775551
Comment 9 Luke Macpherson 2012-09-06 21:53:10 PDT 
Created attachment 162669 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-09-07 00:47:55 PDT 
Comment on attachment 162669 [details]
Patch for landing

Clearing flags on attachment: 162669

Committed r127838: <http://trac.webkit.org/changeset/127838>
Comment 11 WebKit Review Bot 2012-09-07 00:47:59 PDT 
All reviewed patches have been landed.  Closing bug.