Bug 95919 - Rename the ustring() accessor to string()
Summary: Rename the ustring() accessor to string()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 18:07 PDT by Benjamin Poulain
Modified: 2012-09-07 22:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (50.75 KB, patch)
2012-09-05 18:33 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (64.78 KB, patch)
2012-09-05 21:55 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch for landing (65.57 KB, patch)
2012-09-07 22:17 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-09-05 18:07:10 PDT 
Something I promised to do.
Comment 1 Benjamin Poulain 2012-09-05 18:33:54 PDT 
Created attachment 162389 [details]
Patch
Comment 2 Gyuyoung Kim 2012-09-05 19:34:35 PDT 
Comment on attachment 162389 [details]
Patch

Attachment 162389 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13765437
Comment 3 Gyuyoung Kim 2012-09-05 20:13:39 PDT 
Comment on attachment 162389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162389&action=review

This patch needs to be adjusted into below files in order to see green color on eflews.

Tools/DumpRenderTree/efl/TestRunnerEfl.cpp
Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp
Tools/DumpRenderTree/efl/EventSender.cpp

> Source/WebKit/efl/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

I think this description is unneeded.
Comment 4 Benjamin Poulain 2012-09-05 21:26:19 PDT 
Comment on attachment 162389 [details]
Patch

> This patch needs to be adjusted into below files in order to see green color on eflews.
> 
> Tools/DumpRenderTree/efl/TestRunnerEfl.cpp
> Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp
> Tools/DumpRenderTree/efl/EventSender.cpp

Snap! I only checked under Source/
Comment 5 Benjamin Poulain 2012-09-05 21:55:44 PDT 
Created attachment 162415 [details]
Patch
Comment 6 Geoffrey Garen 2012-09-06 18:44:17 PDT 
Comment on attachment 162415 [details]
Patch

rs=me
Comment 7 Benjamin Poulain 2012-09-07 22:17:36 PDT 
Created attachment 162939 [details]
Patch for landing
Comment 8 Benjamin Poulain 2012-09-07 22:45:57 PDT 
Comment on attachment 162939 [details]
Patch for landing

Clearing flags on attachment: 162939

Committed r127958: <http://trac.webkit.org/changeset/127958>
Comment 9 Benjamin Poulain 2012-09-07 22:46:00 PDT 
All reviewed patches have been landed.  Closing bug.