Hi, when trying to build webkit with: build-webkit --gtk --css-filters --disable-accelerated-compositing I get following error: ../../Source/WebCore/rendering/RenderLayer.cpp: In member function ‘void WebCore::RenderLayer::styleChanged(WebCore::StyleDifference, const WebCore::RenderStyle*)’: ../../Source/WebCore/rendering/RenderLayer.cpp:4979:64: error: ‘backing’ was not declared in this scope ../../Source/WebCore/rendering/RenderLayer.cpp:5006:32: error: ‘setBackingNeedsRepaint’ was not declared in this scope
Created attachment 162365 [details] patch proposal
Ccing achicu as he has worked on css filters.
Looks good to me. I think isComposited() is defined in both cases, so maybe the code could look like this instead: bool RenderLayer::paintsWithFilters() const { // FIXME: Eventually there will be more factors than isComposited() to decide whether or not to render the filter if (!renderer()->hasFilter()) return false; if (!isComposited()) return true; #if USE(ACCELERATED_COMPOSITING) if (!m_backing || !m_backing->canCompositeFilters()) return true; #endif return false; }
Created attachment 162376 [details] updated patch
Created attachment 166583 [details] Patch updated patch: remove a pointless change
Comment on attachment 166583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166583&action=review > Source/WebCore/rendering/RenderLayer.cpp:4887 > +#if ENABLE(CSS_FILTERS) && USE(ACCELERATED_COMPOSITING) > bool backingDidCompositeLayers = isComposited() && backing()->canCompositeFilters(); > #endif Can we move |backingDidCompositeLayers| down to the line before it is used?
Created attachment 166944 [details] Patch updated patch to addresse reviewer comment
Comment on attachment 166944 [details] Patch Clearing flags on attachment: 166944 Committed r130331: <http://trac.webkit.org/changeset/130331>
All reviewed patches have been landed. Closing bug.