Bug 95907 – Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const

[Tony Chang]

Created attachment 162367 [details]
Patch

[Tony Chang]

This parallels the changes to computePositionedLogicalHeight/computePositionedLogicalHeightReplaced in http://trac.webkit.org/changeset/126802 .

[Ojan Vafai]

Comment on attachment 162367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162367&action=review

> Source/WebCore/rendering/RenderBox.cpp:2676
> +                                           stretchValues);
> +        computedValues.m_extent = stretchValues.m_extent;
> +        computedValues.m_position = stretchValues.m_position;
> +        computedValues.m_margins.m_start = stretchValues.m_margins.m_start;
> +        computedValues.m_margins.m_end = stretchValues.m_margins.m_end;

Why can't you just pass computedValues in instead of stretchValues?

> Source/WebCore/rendering/RenderBox.cpp:3184
> +    LayoutUnit& marginLogicalLeftAlias = style()->isLeftToRightDirection() ? computedValues.m_margins.m_start : computedValues.m_margins.m_end;
> +    LayoutUnit& marginLogicalRightAlias = style()->isLeftToRightDirection() ? computedValues.m_margins.m_end : computedValues.m_margins.m_start;

Here and elsewhere, these don't look equivalent to me. 

FractionalLayoutUnit& FractionalLayoutBoxExtent::mutableLogicalLeft(WritingMode writingMode)
{
    return isHorizontalWritingMode(writingMode) ? m_left : m_top;
}

[Tony Chang]

Created attachment 162546 [details]
Patch

[Tony Chang]

Comment on attachment 162546 [details]
Patch

Removed stretchValues.

The new code is the same because we want to ignore ltr/rtl, but start/end take that into consideration.  In other words, it's undoing the flipping caused by ltr/rtl.

[WebKit Review Bot]

Comment on attachment 162546 [details]
Patch

Clearing flags on attachment: 162546

Committed r127812: <http://trac.webkit.org/changeset/127812>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.