Bug 95903 - XMLHttpRequest.open does not need custom bindings
Summary: XMLHttpRequest.open does not need custom bindings
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 95972
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-05 15:31 PDT by Adam Barth
Modified: 2023-03-27 08:05 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.87 KB, patch)
2012-09-05 15:33 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-05 15:31:34 PDT 
XMLHttpRequest.open does not need custom bindings
Comment 1 Adam Barth 2012-09-05 15:33:11 PDT 
Created attachment 162351 [details]
Patch
Comment 2 Kentaro Hara 2012-09-05 16:35:57 PDT 
Comment on attachment 162351 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-09-06 02:38:02 PDT 
Comment on attachment 162351 [details]
Patch

Clearing flags on attachment: 162351

Committed r127712: <http://trac.webkit.org/changeset/127712>
Comment 4 WebKit Review Bot 2012-09-06 02:38:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2012-09-06 04:15:34 PDT 
(In reply to comment #3)
> (From update of attachment 162351 [details])
> Clearing flags on attachment: 162351
> 
> Committed r127712: <http://trac.webkit.org/changeset/127712>

It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=95972
Could you check it, please?
Comment 6 mitz 2012-09-06 10:12:35 PDT 
(In reply to comment #3)
> (From update of attachment 162351 [details])
> Clearing flags on attachment: 162351
> 
> Committed r127712: <http://trac.webkit.org/changeset/127712>

I have reverted this change in <http://trac.webkit.org/r127751>, so I am reopening the bug, even though it is likely based on a false premise (“[Optional] works the way XMLHttpRequest expects”).
Comment 7 Adam Barth 2012-09-06 10:40:34 PDT 
We just need to use TreatUndefinedAs and TreatNullAs appropriately.
Comment 8 Adam Barth 2012-09-06 10:51:54 PDT 
Thanks for reverting the patch.