Bug 95900 - Fix export macros in IntegerToStringConversion.h
Summary: Fix export macros in IntegerToStringConversion.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 15:14 PDT by Patrick R. Gansterer
Modified: 2012-09-06 11:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2012-09-05 15:21 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (2.02 KB, patch)
2012-09-05 15:24 PDT, Patrick R. Gansterer 		benjamin: review+
Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2012-09-06 01:05 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-09-05 15:14:15 PDT 
Fix export macros in IntegerToStringConversion.h
Comment 1 Patrick R. Gansterer 2012-09-05 15:21:32 PDT 
Created attachment 162348 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-05 15:23:50 PDT 
Attachment 162348 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Source/WTF/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Patrick R. Gansterer 2012-09-05 15:24:32 PDT 
Created attachment 162350 [details]
Patch
Comment 4 Benjamin Poulain 2012-09-05 21:58:24 PDT 
Comment on attachment 162350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162350&action=review

Let's already r+ this as it is correct.
Feel free to land this patch, or to do the complete cleaning of IntegerToStringConversion.

> Source/WTF/ChangeLog:13
> +        (WTF):

Useless.
Comment 5 Patrick R. Gansterer 2012-09-06 01:05:02 PDT 
Created attachment 162444 [details]
Patch

Land this now, since bug 95940 is more work.
Comment 6 WebKit Review Bot 2012-09-06 11:05:39 PDT 
Comment on attachment 162444 [details]
Patch

Clearing flags on attachment: 162444

Committed r127761: <http://trac.webkit.org/changeset/127761>
Comment 7 WebKit Review Bot 2012-09-06 11:05:42 PDT 
All reviewed patches have been landed.  Closing bug.