Bug 95899 - Three XSLTProcessor functions don't need to be [Custom]
Summary: Three XSLTProcessor functions don't need to be [Custom]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 15:10 PDT by Adam Barth
Modified: 2012-09-06 02:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.35 KB, patch)
2012-09-05 15:16 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-05 15:10:40 PDT 
Three XSLTProcessor functions don't need to be [Custom]
Comment 1 Adam Barth 2012-09-05 15:16:23 PDT 
Created attachment 162347 [details]
Patch
Comment 2 Kentaro Hara 2012-09-05 16:33:32 PDT 
Comment on attachment 162347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162347&action=review

> Source/WebCore/ChangeLog:13
> +        There is a (slight!) difference in behavior. Now, in the case of a type
> +        error, we return null instead of undefined. This change is unlikely to

How do other browsers behave in this case?
Comment 3 Adam Barth 2012-09-05 21:09:29 PDT 
(In reply to comment #2)
> (From update of attachment 162347 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162347&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        There is a (slight!) difference in behavior. Now, in the case of a type
> > +        error, we return null instead of undefined. This change is unlikely to
> 
> How do other browsers behave in this case?

I suspect other browsers throw exception, which we do as well for newer interfaces.  For older interfaces, we tend to use [Optional=DefaultIsUndefined].
Comment 4 Kentaro Hara 2012-09-05 22:11:39 PDT 
Comment on attachment 162347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162347&action=review

>>> Source/WebCore/ChangeLog:13
>>> +        error, we return null instead of undefined. This change is unlikely to
>> 
>> How do other browsers behave in this case?
> 
> I suspect other browsers throw exception, which we do as well for newer interfaces.  For older interfaces, we tend to use [Optional=DefaultIsUndefined].

Thanks for the clarification. Then the change sounds reasonable.
Comment 5 Adam Barth 2012-09-06 00:13:01 PDT 
Comment on attachment 162347 [details]
Patch

Thanks for the review.
Comment 6 WebKit Review Bot 2012-09-06 02:16:47 PDT 
Comment on attachment 162347 [details]
Patch

Clearing flags on attachment: 162347

Committed r127710: <http://trac.webkit.org/changeset/127710>
Comment 7 WebKit Review Bot 2012-09-06 02:16:51 PDT 
All reviewed patches have been landed.  Closing bug.