RESOLVED FIXED 95898
Merge prefix/postfix nodes 
https://bugs.webkit.org/show_bug.cgi?id=95898
Summary Merge prefix/postfix nodes
Gavin Barraclough
Reported 2012-09-05 14:53:37 PDT
Simplify the AST. This will also mean we have access to m_subscriptHasAssignments when generating a prefix/postfix op applied to a bracket access.
Attachments
Fix (26.41 KB, patch)
2012-09-05 15:03 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-09-05 15:03:09 PDT
Created attachment 162346 [details] Fix
WebKit Review Bot
Comment 2 2012-09-05 15:05:21 PDT
Attachment 162346 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/parser/Nodes.h:599: The parameter name "expr" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/parser/Nodes.h:687: The parameter name "expr" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2012-09-05 15:05:41 PDT
Comment on attachment 162346 [details] Fix r=me
Gavin Barraclough
Comment 4 2012-09-05 16:00:08 PDT
Fixed in r127654
Note You need to log in before you can comment on or make changes to this bug.