Bug 95872 - Build failure with accelerated compositing disabled
Summary: Build failure with accelerated compositing disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: arno.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 10:54 PDT by arno.
Modified: 2012-09-05 20:14 PDT (History)
4 users (show)

See Also:

Attachments
patch proposal (1.68 KB, patch)
2012-09-05 10:59 PDT, arno. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2012-09-05 10:54:09 PDT 
Hi,

when I try to build webkit with:
build-webkit --gtk --disable-accelerated-compositing
the build fails with following error:

../../Source/WebCore/html/canvas/WebGLRenderingContext.cpp: In member function ‘void WebCore::WebGLRenderingContext::markContextChanged()’:
../../Source/WebCore/html/canvas/WebGLRenderingContext.cpp:606:26: error: ‘class WebCore::DrawingBuffer’ has no member named ‘markContentsChanged’
make[1]: *** [Source/WebCore/html/canvas/libWebCore_la-WebGLRenderingContext.lo] Error 1

I think the bug was introduced in #94961
I guess the problem also happens with other ports, but I'm not 100% sure of that.
Comment 1 arno. 2012-09-05 10:59:13 PDT 
Created attachment 162288 [details]
patch proposal
Comment 2 James Robinson 2012-09-05 11:02:37 PDT 
Comment on attachment 162288 [details]
patch proposal

OK
Comment 3 WebKit Review Bot 2012-09-05 20:14:21 PDT 
Comment on attachment 162288 [details]
patch proposal

Clearing flags on attachment: 162288

Committed r127683: <http://trac.webkit.org/changeset/127683>
Comment 4 WebKit Review Bot 2012-09-05 20:14:24 PDT 
All reviewed patches have been landed.  Closing bug.