Bug 95869 - [WK2] Make visited link tracking work in multi-process mode
Summary: [WK2] Make visited link tracking work in multi-process mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 10:38 PDT by Alexey Proskuryakov
Modified: 2012-09-05 11:22 PDT (History)
0 users

See Also:

Attachments
proposed fix (8.60 KB, patch)
2012-09-05 10:44 PDT, Alexey Proskuryakov 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-09-05 10:38:08 PDT 
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2012-09-05 10:44:53 PDT 
Created attachment 162281 [details]
proposed fix
Comment 2 mitz 2012-09-05 10:47:00 PDT 
Comment on attachment 162281 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=162281&action=review

> Source/WebKit2/UIProcess/VisitedLinkProvider.cpp:35
> +using namespace std;

The guidelines now say that you shouldn’t do this: <http://www.webkit.org/coding/coding-style.html#using-in-cpp>.
Comment 3 mitz 2012-09-05 10:48:53 PDT 
Comment on attachment 162281 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=162281&action=review

> Source/WebKit2/ChangeLog:11
> +        was making no sense in mult0process world, so it was let go.

Typo: mult0process.
Comment 4 Alexey Proskuryakov 2012-09-05 11:22:08 PDT 
Committed <http://trac.webkit.org/changeset/127614> with comments addressed, and an additional bug fix in WebContext::disconnectProcess - we were neglecting to call m_visitedLinkProvider.processDidClose().