Bug 95855 – [chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

Currently, we don't accelerate any transform animation if it involves a transform operation that isn't invertible, but this is too strict. If we have, at keyframe one, a scale of 1 and, at keyframe two, a scale of 0, we are perfectly capable of blending between the two. This breaks down if we must resort to matrix interpolation and one of the matrices cannot be decomposed. Matrix interpolation works by decomposing both matrices, blending the decomposed components, and then recomposing. Obviously, this won't work if we can't decompose. We can get into the situation where we must resort to matrix interpolation if the transform operations at adjacent keyframes don't line up, or if matrix transform operations are used explicitly.

Created attachment 162260 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 162260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162260&action=review

> Source/Platform/chromium/public/WebTransformationMatrix.h:82
> +    bool blend(const WebTransformationMatrix& from, double progress);

add WEBKIT_EXPORT here too (the rest of the functions will have this for you on ToT)

Created attachment 162768 [details]
Patch for landing

(In reply to comment #3)
> (From update of attachment 162260 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162260&action=review
>
> > Source/Platform/chromium/public/WebTransformationMatrix.h:82
> > +    bool blend(const WebTransformationMatrix& from, double progress);
>
> add WEBKIT_EXPORT here too (the rest of the functions will have this for you on ToT)

Done.

[WebKit Review Bot]

Comment on attachment 162768 [details]
Patch for landing

Clearing flags on attachment: 162768

Committed r127868: <http://trac.webkit.org/changeset/127868>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.