Bug 95851 - [EFL] Keep placeholder text visible until first input from user.
Summary: [EFL] Keep placeholder text visible until first input from user.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 07:06 PDT by Kangil Han
Modified: 2012-09-06 03:47 PDT (History)
5 users (show)

See Also:

Attachments
patch (1.32 KB, patch)
2012-09-05 07:08 PDT, Kangil Han 		kenneth: review+
Details | Formatted Diff | Diff
patch (1.33 KB, patch)
2012-09-05 07:51 PDT, Kangil Han 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
patch (1.47 KB, patch)
2012-09-05 19:40 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-09-05 07:06:56 PDT 
Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Comment 1 Kangil Han 2012-09-05 07:08:08 PDT 
Created attachment 162239 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2012-09-05 07:34:29 PDT 
Comment on attachment 162239 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162239&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.h:211
> +    virtual bool shouldShowPlaceholderWhenFocused() const { return true; }

no OVERRIDE?
Comment 3 Kangil Han 2012-09-05 07:51:10 PDT 
Created attachment 162244 [details]
patch

Done!
Comment 4 Gyuyoung Kim 2012-09-05 08:15:49 PDT 
Comment on attachment 162244 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162244&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.h:211
> +    virtual bool shouldShowPlaceholderWhenFocused() const OVERRIDE { return true; }

I think it is better to move this virtual function to virtual function list side.
Comment 5 Gyuyoung Kim 2012-09-05 08:18:45 PDT 
Comment on attachment 162244 [details]
patch

Oops, Kenneth r+ is removed. So,  I set r+ again.
Comment 6 Kangil Han 2012-09-05 19:40:09 PDT 
Created attachment 162397 [details]
patch

Done!
Comment 7 WebKit Review Bot 2012-09-06 03:47:21 PDT 
Comment on attachment 162397 [details]
patch

Clearing flags on attachment: 162397

Committed r127723: <http://trac.webkit.org/changeset/127723>
Comment 8 WebKit Review Bot 2012-09-06 03:47:25 PDT 
All reviewed patches have been landed.  Closing bug.