Bug 95843 - [CMake] Add notifications path to the WebKit2/CMakeLists.txt
Summary: [CMake] Add notifications path to the WebKit2/CMakeLists.txt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 05:29 PDT by Kihong Kwon
Modified: 2012-09-06 05:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2012-09-05 05:31 PDT, Kihong Kwon 		laszlo.gombos: review+
Details | Formatted Diff | Diff
Patch for landing (1.23 KB, patch)
2012-09-05 18:01 PDT, Kihong Kwon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-09-05 05:29:09 PDT 
Add WebCore/Modules/Notifications path to the WebKit2/CMakeLists.txt.
Because there are some build errors when ENABLE_NOTIFICATIONS feature is enabled.
Comment 1 Kihong Kwon 2012-09-05 05:31:26 PDT 
Created attachment 162227 [details]
Patch
Comment 2 Laszlo Gombos 2012-09-05 07:21:16 PDT 
Comment on attachment 162227 [details]
Patch

Looks good to me. 

Should the ChangeLog title include the [EFL] prefix as well ?
Comment 3 Ryuan Choi 2012-09-05 07:31:00 PDT 
(In reply to comment #2)
> (From update of attachment 162227 [details])
> Looks good to me. 
> 
> Should the ChangeLog title include the [EFL] prefix as well ?

I think that it looks enough because CMakeLists.txt is not port specific. (although only Efl uses WebKit2 among the cmake ports)
Comment 4 Gyuyoung Kim 2012-09-05 08:27:21 PDT 
Comment on attachment 162227 [details]
Patch

I also think this is not port specific. But,it looks [CMAKE] prefix is more useful.
Comment 5 Kihong Kwon 2012-09-05 18:01:33 PDT 
Created attachment 162384 [details]
Patch for landing
Comment 6 WebKit Review Bot 2012-09-06 05:28:56 PDT 
Comment on attachment 162384 [details]
Patch for landing

Clearing flags on attachment: 162384

Committed r127731: <http://trac.webkit.org/changeset/127731>
Comment 7 WebKit Review Bot 2012-09-06 05:28:59 PDT 
All reviewed patches have been landed.  Closing bug.