RESOLVED FIXED Bug 95843
[CMake] Add notifications path to the WebKit2/CMakeLists.txt 
https://bugs.webkit.org/show_bug.cgi?id=95843
Summary [CMake] Add notifications path to the WebKit2/CMakeLists.txt
Kihong Kwon
Reported 2012-09-05 05:29:09 PDT
Add WebCore/Modules/Notifications path to the WebKit2/CMakeLists.txt. Because there are some build errors when ENABLE_NOTIFICATIONS feature is enabled.
Attachments
Patch (1.38 KB, patch)
2012-09-05 05:31 PDT, Kihong Kwon 		laszlo.gombos: review+
DetailsFormatted DiffDiff
Patch for landing (1.23 KB, patch)
2012-09-05 18:01 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-09-05 05:31:26 PDT
Created attachment 162227 [details] Patch
Laszlo Gombos
Comment 2 2012-09-05 07:21:16 PDT
Comment on attachment 162227 [details] Patch Looks good to me. Should the ChangeLog title include the [EFL] prefix as well ?
Ryuan Choi
Comment 3 2012-09-05 07:31:00 PDT
(In reply to comment #2) > (From update of attachment 162227 [details]) > Looks good to me. > > Should the ChangeLog title include the [EFL] prefix as well ? I think that it looks enough because CMakeLists.txt is not port specific. (although only Efl uses WebKit2 among the cmake ports)
Gyuyoung Kim
Comment 4 2012-09-05 08:27:21 PDT
Comment on attachment 162227 [details] Patch I also think this is not port specific. But,it looks [CMAKE] prefix is more useful.
Kihong Kwon
Comment 5 2012-09-05 18:01:33 PDT
Created attachment 162384 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-09-06 05:28:56 PDT
Comment on attachment 162384 [details] Patch for landing Clearing flags on attachment: 162384 Committed r127731: <http://trac.webkit.org/changeset/127731>
WebKit Review Bot
Comment 7 2012-09-06 05:28:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.