RESOLVED FIXED Bug 95837
[Qt] Automate the use of AllInOne files in the Qt build 
https://bugs.webkit.org/show_bug.cgi?id=95837
Summary [Qt] Automate the use of AllInOne files in the Qt build
Simon Hausmann
Reported 2012-09-05 03:35:26 PDT
[Qt] Automate the use of AllInOne files in the Qt build
Attachments
Patch (22.57 KB, patch)
2012-09-05 03:37 PDT, Simon Hausmann 		vestbo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-09-05 03:37:41 PDT
Created attachment 162207 [details] Patch
Simon Hausmann
Comment 2 2012-09-05 03:39:21 PDT
With this feature enabled even on a Linux release build the size of the library shrinks by a whole megabyte. I'm wondering if we should enable this by default perhaps. Right now it is the default on Windows and Mac debug builds, but in theory there is a positive impact on release builds, too. Increased visibility to the compiler reduces the need for link time optimization support in the toolchain.
Simon Hausmann
Comment 3 2012-09-05 03:40:47 PDT
FWIW the use of all-in-one files _is_ required for a debug build on Windows. Even with the current use of just SVGAllInOne.cpp we end up with a library that's too big for MSVC 2008 at least to handle. Adding for example AcessibilityAllinOne.cpp gets us juuust below the limit again, but I think we might as well take as much as we can get :)
Tor Arne Vestbø
Comment 4 2012-09-05 03:54:23 PDT
Comment on attachment 162207 [details] Patch nice!
Simon Hausmann
Comment 5 2012-09-21 13:05:47 PDT
Committed r127576: <http://trac.webkit.org/changeset/127576>
Note You need to log in before you can comment on or make changes to this bug.