Bug 95835 – RenderQuote's QUOTE_LANG table should be auto-generated from CLDR

• Status: NEW
• Component: CSS

[Nicholas Shanks]

Bug 93424 added a whole load of quote characters derived from Unicode's CLDR data. These data were entered into the .cpp file by hand, copied from the referenced URL, and will need to be updated any time the CLDR data change, again, by hand. I consider it highly unlikely that such updates will happen in a timely manner, as no-one will be looking out for them.

Option 1:
Instead an auto-generated file should be created by the build process to keep the table up-to-date, using the latest CLDR XML data which the build machine will need to have available, or be able to retrieve over the network.

Option 2:
Create some scripts which take everything WebKit needs from CLDR and performs all necessary operations on the data. These scripts can then be manually run every time there is a new CLDR release (instead of at build-time).

I haven't found exactly where the quote characters are specified in CLDR.

[Nicholas Shanks]

Also see bug 95836

[Elliott Sprehn]

This should be a script that you run that downloads the XML and transforms it into a cpp/h file. We can't do it at build time because the CLDR being down, or you not having an internet connection, would prevent you from building a working webkit.

The quotations are stored in each language XML

http://unicode.org/cldr/trac/browser/trunk/common/main/en.xml

<delimiters>
  <quotationStart>“</quotationStart>
  <quotationEnd>”</quotationEnd>
  <alternateQuotationStart>‘</alternateQuotationStart>
  <alternateQuotationEnd>’</alternateQuotationEnd>
</delimiters>

This would be a nice change. :)

[Brent Fulgham]

Although the code has changed a bit, this suggestion is still relevant.

[Radar WebKit Bug Importer]

<rdar://problem/96962234>

[Myles C. Maxfield]

+1 on this, we should definitely do this.

I think there's a larger question of "how to call ICU functions at build time" which would be preferable to ingesting raw CLDR data. I'm currently in discussions with Apple's build teams about the right way to do this.