RESOLVED FIXED Bug 95829
[Tests] We should have mouse events test for multiple fields time input UI 
https://bugs.webkit.org/show_bug.cgi?id=95829
Summary [Tests] We should have mouse events test for multiple fields time input UI
yosin
Reported 2012-09-05 01:22:16 PDT
There are no test cases for mouse events on multiple fields time input UI.
Attachments
Patch 1 (4.18 KB, patch)
2012-09-05 01:51 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (4.17 KB, patch)
2012-09-05 03:05 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (4.16 KB, patch)
2012-09-05 03:21 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-09-05 01:51:49 PDT
Created attachment 162187 [details] Patch 1
yosin
Comment 2 2012-09-05 01:52:18 PDT
Comment on attachment 162187 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-09-05 02:02:18 PDT
Comment on attachment 162187 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=162187&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:54 > +mouseMoveTo(40, 15); This is really font-dependent. Please specify font-family:ahem; to avoid platform-dependency as possible.
yosin
Comment 4 2012-09-05 03:05:21 PDT
Created attachment 162201 [details] Patch 2
yosin
Comment 5 2012-09-05 03:06:20 PDT
Comment on attachment 162201 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Set font-family of "time" input element to "ahem".
Kent Tamura
Comment 6 2012-09-05 03:16:09 PDT
Comment on attachment 162201 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=162201&action=review > LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:21 > +var input = document.getElementById("input"); > +input.setAttribute("style", "font-family:ahem"); Why don't you specify it in HTML? <input id=input type=time style="font-family:ahem"> Also, you should specify font-size too because the default size is platform-dependent.
yosin
Comment 7 2012-09-05 03:21:35 PDT
Created attachment 162204 [details] Patch 3
yosin
Comment 8 2012-09-05 03:22:46 PDT
Comment on attachment 162204 [details] Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Set font-family and font-size in HTML for input type "time"
Kent Tamura
Comment 9 2012-09-05 03:25:34 PDT
Comment on attachment 162204 [details] Patch 3 ok. Please watch buildbot status carefully after landing this.
yosin
Comment 10 2012-09-05 18:00:58 PDT
Comment on attachment 162204 [details] Patch 3 Clearing flags on attachment: 162204 Committed r127668: <http://trac.webkit.org/changeset/127668>
yosin
Comment 11 2012-09-05 18:01:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.