RESOLVED FIXED 95828
[EFL] Remove unnecessary logic in ewk_frame_source_get. 
https://bugs.webkit.org/show_bug.cgi?id=95828
Summary [EFL] Remove unnecessary logic in ewk_frame_source_get.
Kangil Han
Reported 2012-09-05 01:10:46 PDT
ewk_frame_source_get has unnecessary logic that has never been used in any case.
Attachments
patch (1.56 KB, patch)
2012-09-06 05:45 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-09-06 05:45:09 PDT
Created attachment 162483 [details] patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-09-06 06:13:18 PDT
Comment on attachment 162483 [details] patch Could we have a test for this?
Kangil Han
Comment 3 2012-09-06 06:34:47 PDT
(In reply to comment #2) > (From update of attachment 162483 [details]) > Could we have a test for this? This patch doesn't create a new API. Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. :-)
Kenneth Rohde Christiansen
Comment 4 2012-09-06 06:36:50 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 162483 [details] [details]) > > Could we have a test for this? > > This patch doesn't create a new API. > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. > :-) Still this can be tested. Like add a test not adding <html> etc and show that it still works.
WebKit Review Bot
Comment 5 2012-09-06 07:38:07 PDT
Comment on attachment 162483 [details] patch Clearing flags on attachment: 162483 Committed r127740: <http://trac.webkit.org/changeset/127740>
WebKit Review Bot
Comment 6 2012-09-06 07:38:11 PDT
All reviewed patches have been landed. Closing bug.
Ryuan Choi
Comment 7 2012-09-06 07:51:17 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 162483 [details] [details] [details]) > > > Could we have a test for this? > > > > This patch doesn't create a new API. > > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. > > :-) > > Still this can be tested. Like add a test not adding <html> etc and show that it still works. I agree with you. we need to test this. But I think that wk1 test framework should be improved. I think that we can create new bug for it now and make test case after bug 94925 landed.
Note You need to log in before you can comment on or make changes to this bug.