ewk_frame_source_get has unnecessary logic that has never been used in any case.
Created attachment 162483 [details] patch
Comment on attachment 162483 [details] patch Could we have a test for this?
(In reply to comment #2) > (From update of attachment 162483 [details]) > Could we have a test for this? This patch doesn't create a new API. Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. :-)
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 162483 [details] [details]) > > Could we have a test for this? > > This patch doesn't create a new API. > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. > :-) Still this can be tested. Like add a test not adding <html> etc and show that it still works.
Comment on attachment 162483 [details] patch Clearing flags on attachment: 162483 Committed r127740: <http://trac.webkit.org/changeset/127740>
All reviewed patches have been landed. Closing bug.
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 162483 [details] [details] [details]) > > > Could we have a test for this? > > > > This patch doesn't create a new API. > > Rather it removed unnecessary source lines in existing WK1 API, found while removing '+=' usage in String. See BUG 95808. > > :-) > > Still this can be tested. Like add a test not adding <html> etc and show that it still works. I agree with you. we need to test this. But I think that wk1 test framework should be improved. I think that we can create new bug for it now and make test case after bug 94925 landed.