Bug 95824 - Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
Summary: Test cases for Up/Down key behavior on field which has maximum/minimum in mul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-05 00:18 PDT by yosin
Modified: 2012-09-05 00:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (3.35 KB, patch)
2012-09-05 00:33 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (3.33 KB, patch)
2012-09-05 00:53 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-05 00:18:23 PDT 
There is no test cases for this edge case.
Comment 1 yosin 2012-09-05 00:33:50 PDT 
Created attachment 162175 [details]
Patch 1
Comment 2 yosin 2012-09-05 00:34:17 PDT 
Comment on attachment 162175 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-09-05 00:36:45 PDT 
Comment on attachment 162175 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=162175&action=review

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:113
> +beginTest('Up/Down keys on maximum value', '12:59:59.999');

Up/Down keys -> Up key

> LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:123
> +beginTest('Up/Down keys on minimum value', '01:00');

Up/Down keys -> Down key
Comment 4 yosin 2012-09-05 00:53:39 PDT 
Created attachment 162179 [details]
Patch 2
Comment 5 yosin 2012-09-05 00:55:42 PDT 
Comment on attachment 162179 [details]
Patch 2

Clearing flags on attachment: 162179

Committed r127562: <http://trac.webkit.org/changeset/127562>
Comment 6 yosin 2012-09-05 00:55:46 PDT 
All reviewed patches have been landed.  Closing bug.