Bug 95820 - [BlackBerry] Remove feature about:cache/disable and about:cache/enable
Summary: [BlackBerry] Remove feature about:cache/disable and about:cache/enable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 22:46 PDT by Jason Liu
Modified: 2012-09-07 10:09 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2012-09-04 22:50 PDT, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2012-09-07 08:58 PDT, Rob Buis
yong.li.webkit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Liu 2012-09-04 22:46:38 PDT
Remove this feature since we need to add a button in settings.
Comment 1 Jason Liu 2012-09-04 22:50:49 PDT
Created attachment 162162 [details]
Patch
Comment 2 Rob Buis 2012-09-05 04:16:44 PDT
Comment on attachment 162162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162162&action=review

Ok.

> Source/WebKit/blackberry/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Any internal Pr or reviewer? If so state them here please.
Comment 3 Yong Li 2012-09-05 07:44:54 PDT
(In reply to comment #0)
> Remove this feature since we need to add a button in settings.

is the button ready yet?
Comment 4 Jason Liu 2012-09-05 18:53:57 PDT
(In reply to comment #3)
> (In reply to comment #0)
> > Remove this feature since we need to add a button in settings.
> 
> is the button ready yet?

Yes, it is ready.
Comment 5 WebKit Review Bot 2012-09-05 19:12:20 PDT
Comment on attachment 162162 [details]
Patch

Clearing flags on attachment: 162162

Committed r127680: <http://trac.webkit.org/changeset/127680>
Comment 6 WebKit Review Bot 2012-09-05 19:12:23 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Rob Buis 2012-09-07 08:58:09 PDT
Reopening to attach new patch.
Comment 8 Rob Buis 2012-09-07 08:58:11 PDT
Created attachment 162784 [details]
Patch
Comment 9 Rob Buis 2012-09-07 10:09:27 PDT
Committed r127881: <http://trac.webkit.org/changeset/127881>