WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95819
[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
https://bugs.webkit.org/show_bug.cgi?id=95819
Summary
[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
James Robinson
Reported
2012-09-04 22:44:03 PDT
[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
Attachments
Patch
(2.37 KB, patch)
2012-09-04 22:45 PDT
,
James Robinson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
James Robinson
Comment 1
2012-09-04 22:45:17 PDT
Created
attachment 162160
[details]
Patch
James Robinson
Comment 2
2012-09-04 22:49:00 PDT
The test value here is marginal, but this is important for the component build in a rather convoluted way. When use_libcc_for_compositor=1, the implementations of the Web*Layer::create() family of static functions are in a static_library webkit/compositor_bindings/compositor_bindings.gyp:webkit_compositor_bindings instead of in a bunch of .cpp files in the webkit sources list. Because of this, these symbols are linked into a separate lib that is then linked into webkit.dll. If any symbols from this .lib are completely unreferenced, they're dropped from webkit.dll even if they have WEBKIT_EXPORT set on them. The fixes are to explicitly pull these in by either a linker flag (like -force_load, /INCLUDE, or /DEF) or to make sure they're referenced in webkit.dll. Since we link the unit tests into webkit.dll, that appears to do the trick.
Adam Barth
Comment 3
2012-09-05 10:15:03 PDT
Comment on
attachment 162160
[details]
Patch That seems a bit hacky, but ok.
James Robinson
Comment 4
2012-09-05 10:34:56 PDT
More than a bit! The test coverage is marginally useful on its own, though.
WebKit Review Bot
Comment 5
2012-09-05 19:07:17 PDT
Comment on
attachment 162160
[details]
Patch Clearing flags on attachment: 162160 Committed
r127678
: <
http://trac.webkit.org/changeset/127678
>
WebKit Review Bot
Comment 6
2012-09-05 19:07:21 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug