Bug 95819 - [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
Summary: [chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 22:44 PDT by James Robinson
Modified: 2012-09-05 19:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2012-09-04 22:45 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-09-04 22:44:03 PDT 
[chromium] Test WebSolidColorLayer in WebLayerTest.Client unit test
Comment 1 James Robinson 2012-09-04 22:45:17 PDT 
Created attachment 162160 [details]
Patch
Comment 2 James Robinson 2012-09-04 22:49:00 PDT 
The test value here is marginal, but this is important for the component build in a rather convoluted way. When use_libcc_for_compositor=1, the implementations of the Web*Layer::create() family of static functions are in a static_library webkit/compositor_bindings/compositor_bindings.gyp:webkit_compositor_bindings instead of in a bunch of .cpp files in the webkit sources list.  Because of this, these symbols are linked into a separate lib that is then linked into webkit.dll.  If any symbols from this .lib are completely unreferenced, they're dropped from webkit.dll even if they have WEBKIT_EXPORT set on them.  The fixes are to explicitly pull these in by either a linker flag (like -force_load, /INCLUDE, or /DEF) or to make sure they're referenced in webkit.dll.  Since we link the unit tests into webkit.dll, that appears to do the trick.
Comment 3 Adam Barth 2012-09-05 10:15:03 PDT 
Comment on attachment 162160 [details]
Patch

That seems a bit hacky, but ok.
Comment 4 James Robinson 2012-09-05 10:34:56 PDT 
More than a bit!  The test coverage is marginally useful on its own, though.
Comment 5 WebKit Review Bot 2012-09-05 19:07:17 PDT 
Comment on attachment 162160 [details]
Patch

Clearing flags on attachment: 162160

Committed r127678: <http://trac.webkit.org/changeset/127678>
Comment 6 WebKit Review Bot 2012-09-05 19:07:21 PDT 
All reviewed patches have been landed.  Closing bug.