Bug 95818 - Fix the uses of String::operator+=() for Mac
Summary: Fix the uses of String::operator+=() for Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 22:09 PDT by Benjamin Poulain
Modified: 2012-09-05 10:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.72 KB, patch)
2012-09-04 22:55 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-09-04 22:09:29 PDT 
Fix the uses of String::operator+=() for Mac
Comment 1 Benjamin Poulain 2012-09-04 22:55:28 PDT 
Created attachment 162163 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-05 04:07:07 PDT 
Comment on attachment 162163 [details]
Patch

Clearing flags on attachment: 162163

Committed r127574: <http://trac.webkit.org/changeset/127574>
Comment 3 WebKit Review Bot 2012-09-05 04:07:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2012-09-05 08:14:36 PDT 
Comment on attachment 162163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162163&action=review

> Source/JavaScriptCore/parser/Parser.h:794
>      NEVER_INLINE void updateErrorWithNameAndMessage(const char* beforeMsg, String name, const char* afterMsg)

Surprised to see String here rather than const String&.
Comment 5 Benjamin Poulain 2012-09-05 10:28:23 PDT 
> Surprised to see String here rather than const String&.

I did not even notice. It is bizarre indeed.