Bug 95813 - Layout Test fast/innerHTML/innerHTML-iframe.html is failing
Summary: Layout Test fast/innerHTML/innerHTML-iframe.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 18:47 PDT by Kenichi Ishibashi
Modified: 2012-10-01 01:26 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2012-09-06 12:17 PDT, Sergey Glazunov 		no flags Details | Formatted Diff | Diff
Patch for landing (3.55 KB, patch)
2012-09-30 19:08 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-09-04 18:47:50 PDT 
The following layout test is failing

fast/innerHTML/innerHTML-iframe.html

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=innerHTML-iframe.html

Probable cause:
http://trac.webkit.org/changeset/127534

Morrita, could you take a look?
Comment 1 Kenichi Ishibashi 2012-09-04 20:33:45 PDT 
Removed platform specific expectation.
http://trac.webkit.org/changeset/127546
Comment 2 Kenichi Ishibashi 2012-09-05 18:01:14 PDT 
Looks flaky. Updated expectation.
http://trac.webkit.org/changeset/127667
Comment 3 Sergey Glazunov 2012-09-06 12:17:45 PDT 
Created attachment 162553 [details]
Patch

It's my fault :(
Comment 4 Kentaro Hara 2012-09-06 15:54:42 PDT 
Comment on attachment 162553 [details]
Patch

Looks OK.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-09-29 09:19:39 PDT 
Hi, is there anything still blocking the change from being committed or can I cq+ it?
Comment 6 Hajime Morrita 2012-09-30 18:18:18 PDT 
Comment on attachment 162553 [details]
Patch

I don't think so.
Comment 7 Hajime Morrita 2012-09-30 18:18:48 PDT 
Comment on attachment 162553 [details]
Patch

Looks too old. I'll update and land this.
Comment 8 Hajime Morrita 2012-09-30 19:08:47 PDT 
Created attachment 166399 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-09-30 19:45:31 PDT 
Comment on attachment 166399 [details]
Patch for landing

Clearing flags on attachment: 166399

Committed r130003: <http://trac.webkit.org/changeset/130003>
Comment 10 WebKit Review Bot 2012-09-30 19:45:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Raphael Kubo da Costa (:rakuco) 2012-10-01 01:26:32 PDT 
Thanks a lot. For future reference, I have unskipped the test for the EFL port in <http://trac.webkit.org/changeset/130012>