Bug 95811 – WebKit2 IPC always sends strings using 16 bit data format

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Michael Saboff]

Strings are sent using 16 bit data format even if the underlying string is an 8 bit string.

[Michael Saboff]

Created attachment 162356 [details]
Patch

[WebKit Review Bot]

Attachment 162356 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Created attachment 162359 [details]
Patch with ChangeLog tab removed

[Benjamin Poulain]

Comment on attachment 162359 [details]
Patch with ChangeLog tab removed

View in context: https://bugs.webkit.org/attachment.cgi?id=162359&action=review

Woot! Very nice.

> Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp:105
> +        encoder->encodeFixedLengthData(reinterpret_cast<const uint8_t*>(string.characters()), length * sizeof(UChar), __alignof(UChar));

This should be characters16().
String::characters() is the "weak" version.

[Michael Saboff]

(In reply to comment #4)
> (From update of attachment 162359 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162359&action=review
> 
> Woot! Very nice.
> 
> > Source/WebKit2/Platform/CoreIPC/ArgumentCoders.cpp:105
> > +        encoder->encodeFixedLengthData(reinterpret_cast<const uint8_t*>(string.characters()), length * sizeof(UChar), __alignof(UChar));
> 
> This should be characters16().
> String::characters() is the "weak" version.

You're right.  The isNull() makes the is8Bit(), characters8() and characters16() accesses all safe.

Thanks for the review, I'll land manually.

[Michael Saboff]

Committed r127753: <http://trac.webkit.org/changeset/127753>