Bug 95809 - JSC: Allow the YarrJIT to use the assembler even when useJIT() is false
Summary: JSC: Allow the YarrJIT to use the assembler even when useJIT() is false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 18:25 PDT by Mark Lam
Modified: 2012-09-04 22:12 PDT (History)
1 user (show)

See Also:

Attachments
Fix. (3.89 KB, patch)
2012-09-04 18:27 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Removed unrelated file from patch. (2.55 KB, patch)
2012-09-04 18:30 PDT, Mark Lam 		ggaren: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
svn up and retry. (2.58 KB, patch)
2012-09-04 21:40 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-09-04 18:25:18 PDT 
Allow the YarrJIT to use the assembler even when useJIT() is false.  Introduce the useYarrJIT() option.

Without this, the YarrJIT was turned off for the llint C loop just because useJIT() is false.
Comment 1 Mark Lam 2012-09-04 18:27:28 PDT 
Created attachment 162145 [details]
Fix.
Comment 2 Mark Lam 2012-09-04 18:30:37 PDT 
Created attachment 162146 [details]
Removed unrelated file from patch.
Comment 3 Geoffrey Garen 2012-09-04 18:34:03 PDT 
Comment on attachment 162146 [details]
Removed unrelated file from patch.

r=me
Comment 4 Build Bot 2012-09-04 19:02:00 PDT 
Comment on attachment 162146 [details]
Removed unrelated file from patch.

Attachment 162146 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13740758
Comment 5 Mark Lam 2012-09-04 21:40:24 PDT 
Created attachment 162156 [details]
svn up and retry.
Comment 6 Mark Lam 2012-09-04 21:41:36 PDT 
The previous patch failed with the following message at the top:
Failed to run "['/home/buildbot/WebKit/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id..." exit_code: 2

Not sure why it should fail to patch / build on the win-ews.  It builds fine for me locally.  Retrying with the patch after an svn up.
Comment 7 Geoffrey Garen 2012-09-04 21:47:27 PDT 
Comment on attachment 162156 [details]
svn up and retry.

r=me
Comment 8 WebKit Review Bot 2012-09-04 22:12:03 PDT 
Comment on attachment 162156 [details]
svn up and retry.

Clearing flags on attachment: 162156

Committed r127554: <http://trac.webkit.org/changeset/127554>
Comment 9 WebKit Review Bot 2012-09-04 22:12:07 PDT 
All reviewed patches have been landed.  Closing bug.