Bug 95800 - Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
Summary: Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2012-09-04 17:28 PDT by Adam Barth
Modified: 2012-09-04 22:33 PDT (History)
6 users (show)

See Also:

Patch (5.06 KB, patch)
2012-09-04 17:29 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-04 17:28:20 PDT
Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp
Comment 1 Adam Barth 2012-09-04 17:29:15 PDT
Created attachment 162138 [details]
Comment 2 Benjamin Poulain 2012-09-04 18:17:14 PDT
Comment on attachment 162138 [details]

The patch looks good.

I remember we had issues before with StylePropertySet::getLayeredShorthandValue(). Would it be possible some code is actually expecting an empty value?
Comment 3 Adam Barth 2012-09-04 22:28:13 PDT
Comment on attachment 162138 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=162138&action=review

> Source/WebCore/css/StylePropertySet.cpp:428
> +    if (result.isEmpty())
> +        return String();

As far I as can tell, the problem was fixed by adding these two lines.
Comment 4 Benjamin Poulain 2012-09-04 22:30:04 PDT
I'll land manually if you don't mind, that will make my life easier on the Mac port.
Comment 5 Benjamin Poulain 2012-09-04 22:33:25 PDT
Comment on attachment 162138 [details]

Clearing flags on attachment: 162138

Committed r127555: <http://trac.webkit.org/changeset/127555>
Comment 6 Benjamin Poulain 2012-09-04 22:33:28 PDT
All reviewed patches have been landed.  Closing bug.