Bug 95799 - Layout Test touchadjustment/iframe-boundary.html is failing
Summary: Layout Test touchadjustment/iframe-boundary.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 17:21 PDT by Kenichi Ishibashi
Modified: 2012-10-08 16:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.63 KB, patch)
2012-09-07 04:16 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-09-04 17:21:39 PDT
See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=iframe-boundary.html

The following layout test is failing

touchadjustment/iframe-boundary.html

Probable cause:
http://trac.webkit.org/changeset/127457
Comment 1 Kenichi Ishibashi 2012-09-04 17:30:10 PDT
Supression committed.
http://trac.webkit.org/changeset/127533
Comment 2 Allan Sandfeld Jensen 2012-09-06 02:16:10 PDT
Apparently the EWS bot was failing when I had it test the last patch. I need someone from chromium to tell me how much the platforms differs so we can fudge the tests to be lenient enough to work on all platforms, but still be a meaningful test.
Comment 3 Allan Sandfeld Jensen 2012-09-07 04:16:00 PDT
Created attachment 162736 [details]
Patch
Comment 4 Allan Sandfeld Jensen 2012-09-07 04:17:19 PDT
(In reply to comment #3)
> Created an attachment (id=162736) [details]
> Patch

The patch is based on analysing the error margins. I haven't had the chance to test it on the failing platform.
Comment 5 Kenichi Ishibashi 2012-09-07 04:32:38 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=162736) [details] [details]
> > Patch
> 
> The patch is based on analysing the error margins. I haven't had the chance to test it on the failing platform.

The cause of the failure was flawed test? Then, I think you can just land the patch. Chromium WebKit gardener will let you know if there is a problem.
Comment 6 Allan Sandfeld Jensen 2012-09-07 05:58:57 PDT
Committed r127863: <http://trac.webkit.org/changeset/127863>
Comment 7 Eric Seidel (no email) 2012-10-08 16:14:27 PDT
Comment on attachment 162736 [details]
Patch

Cleared review? from attachment 162736 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).