RESOLVED FIXED 95787
Add a const version of RenderBox::computeLogicalHeight 
https://bugs.webkit.org/show_bug.cgi?id=95787
Summary Add a const version of RenderBox::computeLogicalHeight
Tony Chang
Reported 2012-09-04 15:18:18 PDT
Add a const version of RenderBox::computeLogicalHeight
Attachments
Patch (11.62 KB, patch)
2012-09-04 15:25 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.61 KB, patch)
2012-09-04 16:33 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-09-04 15:25:42 PDT
Created attachment 162110 [details] Patch
Tony Chang
Comment 2 2012-09-04 15:35:33 PDT
Comment on attachment 162110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162110&action=review > Source/WebCore/rendering/RenderBox.cpp:1972 > + computedValues.m_extent = logicalHeight(); > + computedValues.m_position = logicalTop(); Maybe I should move these into the helper function? > Source/WebCore/rendering/RenderBox.cpp:2139 > + cb->addPercentHeightDescendant(const_cast<RenderBox*>(this)); This is gross, but we do the same thing in other places in the code.
Tony Chang
Comment 3 2012-09-04 16:33:46 PDT
Created attachment 162129 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-09-04 21:14:21 PDT
Comment on attachment 162129 [details] Patch for landing Clearing flags on attachment: 162129 Committed r127549: <http://trac.webkit.org/changeset/127549>
WebKit Review Bot
Comment 5 2012-09-04 21:14:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.