Bug 95785 – [chromium] Move static WebCompositor functions to WebCompositorSupport

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Move static WebCompositor functions to WebCompositorSupport

[James Robinson]

Created attachment 162102 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

The staging on this is awkward, but the plan is to:

1.a) Land this new API
1.b) Land implementations on chromium side
2) Roll everybody forward enough to see these
3) Switch all Chromium callers over to the WebCompositorSupport versions
4) Roll everything forward to see that change
5) Switch all WebKit callers over to WebCompositorSupport versions, empty out WebCompositor interface.


1.a and 1.b can be done concurrently, I think everything has to happen roughly in serial.

[James Robinson]

Created attachment 162109 [details]
add forward declaration of WebThread

[Darin Fisher (:fishd, Google)]

Comment on attachment 162109 [details]
add forward declaration of WebThread

View in context: https://bugs.webkit.org/attachment.cgi?id=162109&action=review

> Source/Platform/chromium/public/WebCompositorSupport.h:62
> +    virtual bool threadingEnabled() { return false; }

nit: add a verb: "isThreadingEnabled"

> Source/Platform/chromium/public/WebCompositorSupport.h:73
> +

nit: extra new line

[James Robinson]

Committed r127672: <http://trac.webkit.org/changeset/127672>