Bug 95785 - [chromium] Move static WebCompositor functions to WebCompositorSupport
Summary: [chromium] Move static WebCompositor functions to WebCompositorSupport
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 14:48 PDT by James Robinson
Modified: 2012-09-05 18:16 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2012-09-04 14:49 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
add forward declaration of WebThread (3.05 KB, patch)
2012-09-04 15:23 PDT, James Robinson 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-09-04 14:48:25 PDT 
[chromium] Move static WebCompositor functions to WebCompositorSupport
Comment 1 James Robinson 2012-09-04 14:49:38 PDT 
Created attachment 162102 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-04 14:51:11 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 James Robinson 2012-09-04 14:52:38 PDT 
The staging on this is awkward, but the plan is to:

1.a) Land this new API
1.b) Land implementations on chromium side
2) Roll everybody forward enough to see these
3) Switch all Chromium callers over to the WebCompositorSupport versions
4) Roll everything forward to see that change
5) Switch all WebKit callers over to WebCompositorSupport versions, empty out WebCompositor interface.


1.a and 1.b can be done concurrently, I think everything has to happen roughly in serial.
Comment 4 James Robinson 2012-09-04 15:23:09 PDT 
Created attachment 162109 [details]
add forward declaration of WebThread
Comment 5 Darin Fisher (:fishd, Google) 2012-09-05 10:50:47 PDT 
Comment on attachment 162109 [details]
add forward declaration of WebThread

View in context: https://bugs.webkit.org/attachment.cgi?id=162109&action=review

> Source/Platform/chromium/public/WebCompositorSupport.h:62
> +    virtual bool threadingEnabled() { return false; }

nit: add a verb: "isThreadingEnabled"

> Source/Platform/chromium/public/WebCompositorSupport.h:73
> +

nit: extra new line
Comment 6 James Robinson 2012-09-05 18:16:18 PDT 
Committed r127672: <http://trac.webkit.org/changeset/127672>