Bug 95781 - [BlackBerry] Rename BlackBerry specific Texture class
Summary: [BlackBerry] Rename BlackBerry specific Texture class
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Arvid Nilsson
Depends on:
Blocks: 114276
  Show dependency treegraph
Reported: 2012-09-04 14:13 PDT by Arvid Nilsson
Modified: 2013-04-10 12:55 PDT (History)
10 users (show)

See Also:

Patch (50.94 KB, patch)
2013-04-10 02:26 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff
Patch (50.73 KB, patch)
2013-04-10 04:01 PDT, Arvid Nilsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-09-04 14:13:36 PDT
BlackBerry port has disabled the Texture related code in FECustomFilter which I think will prevent us from using custom filter in SVG.

We should rename the WebCore/platform/graphics/blackberry/Texture.h Texture class to LayerTexture so we can use gpu/Texture.h with FECustomFilter.
Comment 1 Arvid Nilsson 2013-04-10 01:12:44 PDT
FECustomFilter no longer uses gpu/Texture but instead has a Platform3DObject. However, I still think the rename makes sense to avoid file and class name conflicts in the future.
Comment 2 Arvid Nilsson 2013-04-10 01:33:27 PDT
No longer related to CSS Shaders.
Comment 3 Arvid Nilsson 2013-04-10 02:26:35 PDT
Created attachment 197228 [details]
Comment 4 Arvid Nilsson 2013-04-10 02:27:10 PDT
This is a straight up rename, no functional changes.
Comment 5 Arvid Nilsson 2013-04-10 04:01:45 PDT
Created attachment 197241 [details]

This patch does not actually need to modify FECustomFilter.cpp after all (see comment above), so remove that bit from the Changelog
Comment 6 Rob Buis 2013-04-10 07:37:31 PDT
Comment on attachment 197241 [details]

Comment 7 WebKit Commit Bot 2013-04-10 12:54:58 PDT
Comment on attachment 197241 [details]

Clearing flags on attachment: 197241

Committed r148129: <http://trac.webkit.org/changeset/148129>
Comment 8 WebKit Commit Bot 2013-04-10 12:55:02 PDT
All reviewed patches have been landed.  Closing bug.