Bug 95773 - [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values.
Summary: [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 12:57 PDT by Mike Fenton
Modified: 2012-09-05 11:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2012-09-04 12:59 PDT, Mike Fenton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-09-04 12:57:20 PDT 
Even though PlatformKeyboardEvent::getCurrentModifierState is notImplemented, it should follow the other ports and initialize the values to false to ensure deterministic behaviour.
Comment 1 Mike Fenton 2012-09-04 12:59:15 PDT 
Created attachment 162085 [details]
Patch
Comment 2 Rob Buis 2012-09-04 13:01:30 PDT 
Comment on attachment 162085 [details]
Patch

Looks good.
Comment 3 WebKit Review Bot 2012-09-04 15:29:20 PDT 
Comment on attachment 162085 [details]
Patch

Rejecting attachment 162085 [details] from commit-queue.

New failing tests:
http/tests/cache/subresource-expiration-1.html
http/tests/cache/stopped-revalidation.html
Full output: http://queues.webkit.org/results/13753553
Comment 4 WebKit Review Bot 2012-09-05 11:16:35 PDT 
Comment on attachment 162085 [details]
Patch

Clearing flags on attachment: 162085

Committed r127613: <http://trac.webkit.org/changeset/127613>
Comment 5 WebKit Review Bot 2012-09-05 11:16:37 PDT 
All reviewed patches have been landed.  Closing bug.