Bug 95771 - [BlackBerry] Fix memory leak in InputHandler
Summary: [BlackBerry] Fix memory leak in InputHandler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 12:31 PDT by George Staikos
Modified: 2012-09-04 13:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2012-09-04 12:32 PDT, George Staikos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-09-04 12:31:35 PDT 
The arrays were never deleted in openSelectPopup
Comment 1 George Staikos 2012-09-04 12:32:50 PDT 
Created attachment 162080 [details]
Patch
Comment 2 Rob Buis 2012-09-04 12:39:44 PDT 
Comment on attachment 162080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162080&action=review

Looks good.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1647
> +    delete[] selecteds;

I slightly prefer delete [] foo style. Up to you :)
Comment 3 WebKit Review Bot 2012-09-04 13:21:54 PDT 
Comment on attachment 162080 [details]
Patch

Clearing flags on attachment: 162080

Committed r127493: <http://trac.webkit.org/changeset/127493>
Comment 4 WebKit Review Bot 2012-09-04 13:21:57 PDT 
All reviewed patches have been landed.  Closing bug.