Bug 95769 - [BlackBerry] Provide virtual dtor for DumpRenderTreeClient
Summary: [BlackBerry] Provide virtual dtor for DumpRenderTreeClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-04 12:13 PDT by Rob Buis
Modified: 2012-09-04 13:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.83 KB, patch)
2012-09-04 12:16 PDT, Rob Buis 		yong.li.webkit: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-09-04 12:13:46 PDT 
We have virtual methods in DumpRenderTreeClient but no virtual dtor. This seems wrong since we delete a pointer to it in WebPage, so the subclass dtor in DumpRenderTree is not called.
Comment 1 Rob Buis 2012-09-04 12:16:51 PDT 
Created attachment 162077 [details]
Patch
Comment 2 Rob Buis 2012-09-04 13:16:42 PDT 
Committed r127486: <http://trac.webkit.org/changeset/127486>