Bug 95755 - ResourceErrorBase needs to identify timeouts
Summary: ResourceErrorBase needs to identify timeouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks: 74802 94796
  Show dependency treegraph
 
Reported: 2012-09-04 09:45 PDT by Dominik Röttsches (drott)
Modified: 2012-09-04 13:29 PDT (History)
6 users (show)

See Also:


Attachments
Adding isTimeout property. (3.67 KB, patch)
2012-09-04 11:00 PDT, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-09-04 09:45:12 PDT
For bug 74802 I need to be able to distinguish resource errors which are caused by network timeouts. XHR uses a CachedResourceLoader, which in turn uses a SubResourceLoader. If a load failure occurs there, I'd like to set the status of the Cached resource to a new state TimedOut. I need to be able to identify timeouts in SubResourceLoader to be able to do that. That's why I'd like to introduce this distinction.
Comment 1 Dominik Röttsches (drott) 2012-09-04 11:00:20 PDT
Created attachment 162061 [details]
Adding isTimeout property.
Comment 2 Dominik Röttsches (drott) 2012-09-04 11:39:11 PDT
Thanks for the quick review, Alexey.
Comment 3 WebKit Review Bot 2012-09-04 13:29:46 PDT
Comment on attachment 162061 [details]
Adding isTimeout property.

Clearing flags on attachment: 162061

Committed r127495: <http://trac.webkit.org/changeset/127495>
Comment 4 WebKit Review Bot 2012-09-04 13:29:51 PDT
All reviewed patches have been landed.  Closing bug.