Bug 95744 – [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Koji Ishii]

From https://bugs.webkit.org/show_bug.cgi?id=94822#c9
> Hi, having OpenTypeVerticalData.cpp in both webcore_remaining and
> webcore_platform seems to break incremental linking on Windows
> Chromium. Is it possible to remove it from one of those libraries?

[Koji Ishii]

There was a line for webcore_remaining
        ['OS=="win"', {
          'sources/': [
            ['include', '/opentype/'],
          ],
so, addition of 3 lines to WebCore.gyp in bug 94822 might be not necessary. Testing...

[Koji Ishii]

hmm...I just followed the instructions at wiki to enable incremental linking without luck, so I can't verify the fix. I'm using msbuild with VS2010.

Scott, can you?

[Koji Ishii]

Created attachment 162047 [details]
Patch

[Scott Graham]

Yes, the removal of the three lines in WebCore.gyp makes the incremental build work again.

I'll test now that it doesn't break non-incremental.

[Scott Graham]

Confirmed, this works in both styles of builds.

[Peter Beverloo]

Created attachment 162056 [details]
Patch

[Peter Beverloo]

Committed r127471: <http://trac.webkit.org/changeset/127471>

[Peter Beverloo]

Comment on attachment 162056 [details]
Patch

Committed by request as a buildfix, verified by Scott. Koji also was the person who added these lines initially.