People have reported the following build error when using Ubuntu 11.10: Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:144:10: error: ‘struct sockaddr_nl’ has no member named ‘nl_family’ This builds just fine on Ubuntu 12.04 though. The reason for the compilation order is that on some systems, <sys/socket.h> must be included BEFORE <linux/netlink.h>. Unfortunately, this is against coding style (includes should be in alphabetical order) but I don't think we have a choice here.
Created attachment 161998 [details] Patch
Attachment 161998 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
The style error is expected. We have to code against style here to include headers in a specific order.
Comment on attachment 161998 [details] Patch Clearing flags on attachment: 161998 Committed r127455: <http://trac.webkit.org/changeset/127455>
All reviewed patches have been landed. Closing bug.