Bug 9572 - Add application/xhtml+xml to the Accept header
: Add application/xhtml+xml to the Accept header
Status: RESOLVED FIXED
: WebKit
Page Loading
: 420+
: Macintosh Mac OS X 10.4
: P3 Normal
Assigned To:
: http://ppewww.ph.gla.ac.uk/~flavell/w...
:
:
: 4223
  Show dependency treegraph
 
Reported: 2006-06-25 00:05 PST by
Modified: 2006-07-11 12:03 PST (History)


Attachments
proposed patch (1.64 KB, patch)
2006-07-07 10:57 PST, Alexey Proskuryakov
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2006-06-25 00:05:14 PST
Currently, WebKit sends */* as its Accept header. A common technique for servers is to refrain from sending XHTML in this case, because this is what clients lacking XHTML support (such as IE) send.

This is what Firefox sends for the main resource:
Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
------- Comment #1 From 2006-07-07 10:17:44 PST -------
See also: bug 9426.
------- Comment #2 From 2006-07-07 10:57:59 PST -------
Created an attachment (id=9254) [details]
proposed patch

I am not aware of any reason for us to send something else than Firefox does in the Accept header, so I've just copied theirs.
------- Comment #3 From 2006-07-07 16:27:41 PST -------
(From update of attachment 9254 [details])
What's supplying our current Accept header value?
------- Comment #4 From 2006-07-08 00:54:50 PST -------
(In reply to comment #3)
I couldn't find it in WebCore or WebKit, so it must be NSURLConnection itself.
------- Comment #5 From 2006-07-08 05:50:47 PST -------
(From update of attachment 9254 [details])
This new string will need to be added to StringNotToBeLocalized.txt.

r=me
------- Comment #6 From 2006-07-08 23:59:04 PST -------
(In reply to comment #5)
> This new string will need to be added to StringNotToBeLocalized.txt.

Added (also "max-age=0" from a previous patch).

Committed revision 15246.
------- Comment #7 From 2006-07-11 12:03:57 PST -------
> Committed revision 15246.

.. and 15340 for the test that I missed then.