Bug 95717 - DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound
Summary: DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 95788
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-04 00:48 PDT by Filip Pizlo
Modified: 2012-09-04 18:35 PDT (History)
7 users (show)

See Also:

Attachments
the patch (13.13 KB, patch)
2012-09-04 00:54 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-09-04 00:48:28 PDT 
If profiling tells us that the access may be out of bounds, then we shouldn't speculate that it's in bounds.
Comment 1 Filip Pizlo 2012-09-04 00:54:32 PDT 
Created attachment 161981 [details]
the patch
Comment 2 Filip Pizlo 2012-09-04 14:17:17 PDT 
Landed in http://trac.webkit.org/changeset/127503
Comment 3 Tim Horton 2012-09-04 15:29:41 PDT 
This seems to have caused some failures in fast/js tests; see http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r127507%20(567)/results.html

Per pizlo, I'm going to roll it out.
Comment 4 WebKit Review Bot 2012-09-04 15:29:49 PDT 
Re-opened since this is blocked by 95788
Comment 5 Filip Pizlo 2012-09-04 18:35:46 PDT 
Relanded with fixes in http://trac.webkit.org/changeset/127536