Bug 95712 - [CMAKE] Update cmakeconfig.h.cmake
Summary: [CMAKE] Update cmakeconfig.h.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 23:15 PDT by Jinwoo Song
Modified: 2012-09-04 02:25 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.77 KB, patch)
2012-09-03 23:19 PDT, Jinwoo Song 		gyuyoung.kim: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
patch (3.81 KB, patch)
2012-09-04 01:32 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-09-03 23:15:48 PDT 
Update feature definitions which are missing compared to WebKitFeatures.cmake
and sort the list by alphabet ordering.
Comment 1 Jinwoo Song 2012-09-03 23:19:52 PDT 
Created attachment 161969 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-09-04 00:12:36 PDT 
Comment on attachment 161969 [details]
patch

Looks OK, thanks.
Comment 3 Gyuyoung Kim 2012-09-04 00:24:04 PDT 
Comment on attachment 161969 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161969&action=review

> Source/cmakeconfig.h.cmake:85
> +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO

Wrong alphabetical order.
Comment 4 Jinwoo Song 2012-09-04 01:32:52 PDT 
Created attachment 161985 [details]
patch
Comment 5 Jinwoo Song 2012-09-04 01:33:34 PDT 
(In reply to comment #3)
> (From update of attachment 161969 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161969&action=review
> 
> > Source/cmakeconfig.h.cmake:85
> > +#cmakedefine01 ENABLE_PLUGIN_PROXY_FOR_VIDEO
> 
> Wrong alphabetical order.

Fixed. Thanks for checking my mistake!
Comment 6 WebKit Review Bot 2012-09-04 02:25:01 PDT 
Comment on attachment 161985 [details]
patch

Clearing flags on attachment: 161985

Committed r127451: <http://trac.webkit.org/changeset/127451>
Comment 7 WebKit Review Bot 2012-09-04 02:25:04 PDT 
All reviewed patches have been landed.  Closing bug.