Bug 95710 - [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
Summary: [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 23:02 PDT by Balazs Kelemen
Modified: 2012-09-06 06:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2012-09-03 23:06 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-09-03 23:02:05 PDT 
It has been revealed when I tested a patch that makes a lot of tests failing. In driver.run_test an exception can raise here: 

if stop_when_done or crashed or timed_out:
    # We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output.
    # In the timeout case, we kill the hung process as well.
    out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0)
    text += out
    self.error_from_test += err

at the += if out or err is None.

Although it probably not shown on trunk we should make sure the harness can handle a driver in a bad state.
Comment 1 Balazs Kelemen 2012-09-03 23:06:13 PDT 
Created attachment 161968 [details]
Patch
Comment 2 Balazs Kelemen 2012-09-06 06:20:50 PDT 
Comment on attachment 161968 [details]
Patch

Clearing flags on attachment: 161968

Committed r127734: <http://trac.webkit.org/changeset/127734>
Comment 3 Balazs Kelemen 2012-09-06 06:20:54 PDT 
All reviewed patches have been landed.  Closing bug.