In bug 88616, basic functionality of popup menu is implemented (type and title) This bug implements other members of WebPopupMenu.
Created attachment 161970 [details] Patch
Comment on attachment 161970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161970&action=review > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:53 > + _Ewk_Popup_Menu_Item(Ewk_Popup_Menu_Item_Type _type, const char* _text, Ewk_Text_Direction _textDirection, bool _hasTextDirectionOverride, const char* _toolTip, const char* _accessibilityText, bool _isEnabled, bool _isLabel, bool _isSelected) Why not simply pass a WebKit::WebPopupItem to the constructor? It would be much simpler. > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:119 > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); Should be EINA_SAFETY_ON_NULL_RETURN_VAL(item, false); > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:126 > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); Ditto. > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:133 > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); Ditto. > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:140 > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); Ditto. > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:147 > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); Ditto. > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:154 > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); Ditto.
Created attachment 162017 [details] Patch
(In reply to comment #2) > (From update of attachment 161970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161970&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:53 > > + _Ewk_Popup_Menu_Item(Ewk_Popup_Menu_Item_Type _type, const char* _text, Ewk_Text_Direction _textDirection, bool _hasTextDirectionOverride, const char* _toolTip, const char* _accessibilityText, bool _isEnabled, bool _isLabel, bool _isSelected) > > Why not simply pass a WebKit::WebPopupItem to the constructor? It would be much simpler. > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:119 > > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); > > Should be EINA_SAFETY_ON_NULL_RETURN_VAL(item, false); > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:126 > > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); > > Ditto. > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:133 > > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); > > Ditto. > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:140 > > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); > > Ditto. > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:147 > > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); > > Ditto. > > > Source/WebKit2/UIProcess/API/efl/ewk_popup_menu_item.cpp:154 > > + EINA_SAFETY_ON_NULL_RETURN_VAL(item, 0); > > Ditto. Fixed. thank you.
Comment on attachment 162017 [details] Patch LGTM.
Comment on attachment 162017 [details] Patch Looks good to me.
Comment on attachment 162017 [details] Patch Clearing flags on attachment: 162017 Committed r127686: <http://trac.webkit.org/changeset/127686>