Bug 95689 – [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

In Minibrowser & EWebLauncher, webview lost focus when url bar is clicked.
So, key events are always generated in url bar although user clicked webview.

Below is simple step to reproduce this bug.
1. load google.com
2. click url bar
3. click search field in webview.
4. try to write something.

[Ryuan Choi]

Created attachment 161928 [details]
Patch

[Chris Dumez]

Comment on attachment 161928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review

LGTM but small nits:

> Tools/MiniBrowser/efl/main.c:136
> +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info)

Stars on wrong side.

> Tools/MiniBrowser/efl/main.c:138
> +    Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info;

Shouldn't there be a space before the star?

[Ryuan Choi]

Created attachment 161934 [details]
Patch

[Ryuan Choi]

Created attachment 161935 [details]
Patch

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 161928 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161928&action=review
> 
> LGTM but small nits:
> 
> > Tools/MiniBrowser/efl/main.c:136
> > +on_mouse_down(void* data, Evas* e, Evas_Object* webview, void* event_info)
> 
> Stars on wrong side.
> 
> > Tools/MiniBrowser/efl/main.c:138
> > +    Evas_Event_Mouse_Down *ev = (Evas_Event_Mouse_Down*) event_info;
> 
> Shouldn't there be a space before the star?

Right, Fixed style issues in the codes which I change.

[Chris Dumez]

Comment on attachment 161935 [details]
Patch

LGTM. Thanks.

[Kenneth Rohde Christiansen]

Comment on attachment 161935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161935&action=review

> Tools/ChangeLog:10
> +        So, there are bug that key events are always generated in url bar although
> +        user clicked webview.

Could use a bit more 'the's. although the user clicked on the web view

[Ryuan Choi]

Created attachment 161936 [details]
Patch

[Ryuan Choi]

Comment on attachment 161936 [details]
Patch

I updated comments.
s/webview/the web view/
s/focus/the focus/
s/user/the user/

[WebKit Review Bot]

Comment on attachment 161936 [details]
Patch

Clearing flags on attachment: 161936

Committed r127431: <http://trac.webkit.org/changeset/127431>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.