Bug 95683 - [Qt] Not all activated elements highlighted, but some frames are
Summary: [Qt] Not all activated elements highlighted, but some frames are
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 06:08 PDT by Allan Sandfeld Jensen
Modified: 2012-09-03 12:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2012-09-03 06:11 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-09-03 06:08:06 PDT 
There are cases where we currently fail to show the tap-highlight for the element touch-adjustment has determined should be activated. Also there are cases where we end up tap-highlighting entire frames because they are focusable.
Comment 1 Allan Sandfeld Jensen 2012-09-03 06:11:39 PDT 
Created attachment 161912 [details]
Patch
Comment 2 Peter Beverloo (cr-android ews) 2012-09-03 06:34:09 PDT 
Comment on attachment 161912 [details]
Patch

Attachment 161912 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13740164
Comment 3 Allan Sandfeld Jensen 2012-09-03 07:29:00 PDT 
Comment on attachment 161912 [details]
Patch

The build-failure can not have been caused by this patch.
Comment 4 WebKit Review Bot 2012-09-03 12:14:19 PDT 
Comment on attachment 161912 [details]
Patch

Clearing flags on attachment: 161912

Committed r127432: <http://trac.webkit.org/changeset/127432>
Comment 5 WebKit Review Bot 2012-09-03 12:14:22 PDT 
All reviewed patches have been landed.  Closing bug.