Bug 95682 - Web Inspector: [WebGL] Make the injected __resourceObject property non-enumerable
Summary: Web Inspector: [WebGL] Make the injected __resourceObject property non-enumer...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-03 05:42 PDT by Andrey Adaikin
Modified: 2012-09-03 09:09 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.50 KB, patch)
2012-09-03 05:47 PDT, Andrey Adaikin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2012-09-03 05:42:15 PDT
Make the injected auxiliary property __resourceObject non-enumerable to hide it from for..in iterations.
Comment 1 Andrey Adaikin 2012-09-03 05:47:21 PDT
Created attachment 161906 [details]
Patch
Comment 2 Pavel Feldman 2012-09-03 05:54:20 PDT
Comment on attachment 161906 [details]
Patch

Is there a test?
Comment 3 Andrey Adaikin 2012-09-03 06:04:14 PDT
I don't think we need to test that Object.defineProperty does what the specs says. Otherwise, plz suggest a test case.
Comment 4 WebKit Review Bot 2012-09-03 09:09:30 PDT
Comment on attachment 161906 [details]
Patch

Clearing flags on attachment: 161906

Committed r127426: <http://trac.webkit.org/changeset/127426>
Comment 5 WebKit Review Bot 2012-09-03 09:09:34 PDT
All reviewed patches have been landed.  Closing bug.