We should implement scrollable sublayers in ScrollingCoordinatorChromium.
Created attachment 161929 [details] Patch Patch (requires 78862).
Comment on attachment 161929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161929&action=review > Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp:132 > + MOCK_CONST_METHOD0(isActive, bool()); I don't think you really need a mock here at all - you just need a fake. I'd drop the gmock macros, etc, and just have empty implementations of the pure virtuals > Source/WebKit/chromium/tests/WebLayerTest.cpp:185 > + m_didScrollCalled = true; here, on the flip side, you've basically hand-rolled gmock's EXPECT_CALL :). I would use the gmock macros here since it's a small pure virtual interface
Created attachment 162216 [details] Patch - Added missing WebLayerScrollClient.h. - Not rolling my own test infrastructure :)
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 162216 [details] Patch Great!
Comment on attachment 162216 [details] Patch Clearing flags on attachment: 162216 Committed r127605: <http://trac.webkit.org/changeset/127605>
All reviewed patches have been landed. Closing bug.