WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
UNCONFIRMED
95675
[WK2] Provide asynchronous javascript popup api.
https://bugs.webkit.org/show_bug.cgi?id=95675
Summary
[WK2] Provide asynchronous javascript popup api.
Byungwoo Lee
Reported
2012-09-03 01:40:56 PDT
Efl doesn't support modal popup or nested main loop by the platform side. But with the current webkit implementation, an application that uses webkit should use those, because the apis for creating alert(), confirm(), prompt() popups work as synchronously. So application need to implements some complex way to support modal popup without platform support. Fortunately, WK2 has a sync ipc message with delayed reply. With applying this to the ipc messages for js popup, those apis can work as asynchronouse way on UIProcess side. (WebProcess main run loop will be suspended until the reply for the ipc message is received.) Async api is more flexible than sync api. It has an advantage for the platforms like efl, and it can be used as sync way on some other platforms which can use modal popup or nested main loop.
Attachments
Patch
(14.96 KB, patch)
2012-09-21 02:09 PDT
,
Byungwoo Lee
buildbot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Byungwoo Lee
Comment 1
2012-09-21 02:09:01 PDT
Created
attachment 165083
[details]
Patch
Byungwoo Lee
Comment 2
2012-09-21 02:09:42 PDT
This is a partial patch for providing async api for javascript popup. For the first step, I changed the below sync apis with delayed reply. Messages::WebPageProxy::RunJavaScriptAlert Messages::WebPageProxy::RunJavaScriptConfirm Messages::WebPageProxy::RunJavaScriptPrompt
Build Bot
Comment 3
2012-09-21 02:15:16 PDT
Comment on
attachment 165083
[details]
Patch
Attachment 165083
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13958507
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug