Bug 95670 – [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Chris Dumez]

The layout is incorrect upon resizing the window in Minibrowser / EWebLauncher:
1. The URL bar is not resized accordingly
2. The page is moved behind the URL bar and we miss the top of the page.

[Chris Dumez]

Created attachment 161867 [details]
Patch

[Ryuan Choi]

Comment on attachment 161867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161867&action=review

Thank you for the fixing.

> Tools/EWebLauncher/url_bar.c:85
> +void
> +url_bar_update_size(Url_Bar *urlBar, int width)
> +{

How do you think about url_bar_resize for Efl friendly naming.

> Tools/MiniBrowser/efl/main.c:291
> -    MiniBrowser *browser = browserCreate(url, engine);
> +    browser = browserCreate(url, engine);

IMO, this is not necessary.

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 161867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161867&action=review
> 
> > Tools/MiniBrowser/efl/main.c:291
> > -    MiniBrowser *browser = browserCreate(url, engine);
> > +    browser = browserCreate(url, engine);
> 
> IMO, this is not necessary.

Never mind. In order to simplify issue, this approach is reasonable to me.

[Chris Dumez]

Created attachment 161871 [details]
Patch

Take ryuan's feedback into consideration (thanks!).

[Kenneth Rohde Christiansen]

Comment on attachment 161871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161871&action=review

> Tools/EWebLauncher/main.c:159
> +find_app_with_ee(Ecore_Evas *ee)

from_ee?

[Chris Dumez]

Created attachment 161872 [details]
Patch for landing

Take Kenneth's feedback into consideration.

[WebKit Review Bot]

Comment on attachment 161872 [details]
Patch for landing

Clearing flags on attachment: 161872

Committed r127411: <http://trac.webkit.org/changeset/127411>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.