Bug 95669 – [EFL] Use WebKitVersion.h to get version information

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

The WEBKIT_USER_AGENT_MAJOR_VERSION and WEBKIT_USER_AGENT_MINOR_VERSION
is defined as constant in the OptionsEfl.cmake. But we do not need to define here 
but can use the WebKitVersion.h instead.

WebKitVersion.h is generated with the version information in the Source/WebCore/Configurations/Version.xcconfig.

[Jinwoo Song]

Created attachment 161874 [details]
patch

[Gyuyoung Kim]

Comment on attachment 161874 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161874&action=review

> Source/WebKit/efl/ewk/ewk_settings.cpp:320
> +    WTF::String uaVersion = makeString(String::number(WEBKIT_MAJOR_VERSION), '.', String::number(WEBKIT_MINOR_VERSION), '+');

Use String operator instead of makeString() ?

str = text + 'a' + foo + bar;

This is more efficient way to concatenate strings.

See also : http://trac.webkit.org/wiki/EfficientStrings

> Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:55
> +    version = makeString(String::number(WEBKIT_MAJOR_VERSION), '.',

ditto.

[Jinwoo Song]

Created attachment 161878 [details]
patch

[Jinwoo Song]

(In reply to comment #2)
> (From update of attachment 161874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161874&action=review
> 
> > Source/WebKit/efl/ewk/ewk_settings.cpp:320
> > +    WTF::String uaVersion = makeString(String::number(WEBKIT_MAJOR_VERSION), '.', String::number(WEBKIT_MINOR_VERSION), '+');
> 
> Use String operator instead of makeString() ?
> 
> str = text + 'a' + foo + bar;
> 
> This is more efficient way to concatenate strings.
> 
> See also : http://trac.webkit.org/wiki/EfficientStrings
Done.
> 
> > Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:55
> > +    version = makeString(String::number(WEBKIT_MAJOR_VERSION), '.',
> 
> ditto.
Done.

[Gyuyoung Kim]

Comment on attachment 161878 [details]
patch

You are missing to modify cmakeconfig.h.cmake.

http://trac.webkit.org/browser/trunk/Source/cmakeconfig.h.cmake#L4

[Jinwoo Song]

Created attachment 161888 [details]
patch

[Jinwoo Song]

(In reply to comment #5)
> (From update of attachment 161878 [details])
> You are missing to modify cmakeconfig.h.cmake.
> 
> http://trac.webkit.org/browser/trunk/Source/cmakeconfig.h.cmake#L4

I removed the WEBKIT_USER_AGENT_* definitions in the cmakeconfig.h.cmake, too.

[Gyuyoung Kim]

Comment on attachment 161888 [details]
patch

LGTM

[WebKit Review Bot]

Comment on attachment 161888 [details]
patch

Clearing flags on attachment: 161888

Committed r127419: <http://trac.webkit.org/changeset/127419>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.