Bug 95652 - Don't create access error strings if there is no access error
Summary: Don't create access error strings if there is no access error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 93407
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-02 00:50 PDT by Filip Pizlo
Modified: 2012-09-02 01:34 PDT (History)
8 users (show)

See Also:

Attachments
the patch (2.12 KB, patch)
2012-09-02 00:54 PDT, Filip Pizlo 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-09-02 00:50:50 PDT 
Patch forthcoming.

I'm just trying to undo our 50% regression in pdfjs caused by http://trac.webkit.org/changeset/126165.
Comment 1 Filip Pizlo 2012-09-02 00:54:48 PDT 
Created attachment 161839 [details]
the patch
Comment 2 Adam Barth 2012-09-02 01:02:24 PDT 
Comment on attachment 161839 [details]
the patch

I would just remove the |result| temporary and just early return if shouldAllowAccessToFoo returns true.  Thanks for fixing my regression.
Comment 3 Filip Pizlo 2012-09-02 01:03:11 PDT 
(In reply to comment #2)
> (From update of attachment 161839 [details])
> I would just remove the |result| temporary and just early return if shouldAllowAccessToFoo returns true.  Thanks for fixing my regression.

Good point!  I will do that instead.

Thanks for the quick review!
Comment 4 Filip Pizlo 2012-09-02 01:34:03 PDT 
Landed in http://trac.webkit.org/changeset/127387