Bug 95643 - [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
Summary: [Gtk] accessibility/replaced-objects-in-anonymous-blocks layout test failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-01 06:24 PDT by Joanmarie Diggs
Modified: 2012-09-01 11:16 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2012-09-01 06:29 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
Patch (1.64 KB, patch)
2012-09-01 08:40 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2012-09-01 06:24:46 PDT 
As part of the fix for 72811, a test which needed to be updated was updated by Zan. (Thanks!) One more tweak needs to be made.

Now that my build has finished, I am seeing:

--- /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt
+++ /home/jd/checkout/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-actual.txt
@@ -19,7 +19,8 @@
             AXRole: document frame 
     AXRole: panel AXValue: <obj>text area<\n>
         AXRole: entry AXValue: text area
-    AXRole: push button 
+    AXRole: section AXValue: Div<\n><obj>button
+        AXRole: push button 
     AXRole: heading AXValue: Heading<\n><obj>button<\n><obj>

The push button is inside a div and the div has additional content, so one would expect the div to be in the accessible hierarchy. And in gtk a11y, div == section. Thus the above seems correct. The question is, why didn't the bot where the test originally failed see that?

I'll attach a patch and leave it to the gardeners to sort out the bots. :)
Comment 1 Joanmarie Diggs 2012-09-01 06:29:06 PDT 
Created attachment 161825 [details]
Patch
Comment 2 Joanmarie Diggs 2012-09-01 08:40:53 PDT 
Created attachment 161829 [details]
Patch
Comment 3 WebKit Review Bot 2012-09-01 11:15:57 PDT 
Comment on attachment 161829 [details]
Patch

Clearing flags on attachment: 161829

Committed r127377: <http://trac.webkit.org/changeset/127377>
Comment 4 WebKit Review Bot 2012-09-01 11:16:00 PDT 
All reviewed patches have been landed.  Closing bug.